Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for no_proxy setting #736

Closed
bukovjanmic opened this issue Apr 27, 2022 · 2 comments
Closed

Missing support for no_proxy setting #736

bukovjanmic opened this issue Apr 27, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@bukovjanmic
Copy link

Currently, there is no support for no-proxy setting in Grafana CR.

This creates a problem for our setup, as:

  • grafana needs a proxy to download plugin during startup, or dashboards from grafana.com
  • grafana needs to talk to internal SSO server (OIDC protocol) to authneticate users

The internal SSO server is not reachable via proxy.

Currently, we use a workaround like this:

  deployment:
    env:
      - name: NO_PROXY
        value: '.cluster.local,.svc,.example.com,localhost'
    httpProxy:
      enabled: true
      url: 'http://http-proxy.example.com:8080'
      secureUrl: 'http://http-proxy.example.com:8080'

But we think this is neither documented, nor clean.

A good solution would be to be able to declare noProxy setting along httpProxy definition.

Even greater solution would be if the operator could automatically use a Proxy setting - including no proxy - defined on Opemshift cluster (available in apiVersion: config.openshift.io/v1, kind: Proxy, metadata.name: name: cluster), but I guess that would be too specific for Openshift deployment

Thanks,

Michal

@bukovjanmic bukovjanmic added enhancement New feature or request needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 27, 2022
@NissesSenap NissesSenap added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 8, 2022
@NissesSenap
Copy link
Collaborator

Hi @bukovjanmic I think you make a valid point.

Just as you say doing some config.openshift.io/v1 would be a bit to openshift specific but since we support specifying httpProxy specifically I don't see why we don't support NO_PROXY as well.

I guess from a point of view we should have spiked this feature and pointed on pure environment variables but there was probably a good reason for implementing it.

Would you be willing to add the NO_PROXY feature?

@NissesSenap
Copy link
Collaborator

This have been solved with #778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants