How to handle upgrade of CRDs with Helm

[alternaivan]

Hi there!

In Helm documentation for CRDs, the upgrade of them is currently not supported. See this link.

In your CONTRIBUTING.md it's stated that with the CRD upgrade the helm chart will also get an upgrade.

Initial installation of the grafana-operator helm chart will install the CRDs as well. My question is - when CRDs get an update, how will the helm upgrade of the chart be handled?

One possible solution would be to add parameter to values.yaml that will enable or disable installation of CRDs, so that they can be manually upgraded.

crds:
  enable: false

What do you think?

Thanks,
Marjan

[NissesSenap]

Hi @alternaivan
So the contributing guide isn't mean, as it will update the CRD automatically on your cluster. It is, if you update the CRD in the code and you then run make manifests, it will update the helm chart CRDs automatically.

Just as you say the CRDs won't get updated using helm, and we have pointed that out here https://grafana-operator.github.io/grafana-operator/blog/2023/03/14/version-5-getting-started/#helm-crd-caveats, but we should probably point it out in the docs as well.

I think your idea about adding a new flag that is, sounds good.
We only have to take the manifests generation in to account, when running make manifests
.

So other than updating the values file, you also need to inject some kind of helm template value on top of the CRD files so you can remove the creation of it.

We would love a PR for the helm chart and get documentation on how you could update the CRDs manually using kustomize or something similar.

[NissesSenap]

A potential solution is to release the CRDs as a separate artifact as part of our release. See comments in #1373

[NissesSenap]

In our next release, we will start to publish the CRDs separately. We should be able to use a simple kubectl apply to fix it.
We just need to document it.