Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management of Teams within Grafana "Main Org" Only #1297

Open
xorima opened this issue Nov 6, 2023 · 6 comments
Open

Management of Teams within Grafana "Main Org" Only #1297

xorima opened this issue Nov 6, 2023 · 6 comments
Labels
approved enhancement New feature or request triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@xorima
Copy link

xorima commented Nov 6, 2023

Is your feature request related to a problem? Please describe.
I need to be able to permission folders based on teams within Grafana. Today this operator solves the folder permissions but not the creation of teams.

This was previously discussed on #549 but I am looking for a refined scope of just Teams within the default org.

Describe the solution you'd like
To be able to list the team I want and the usernames of the people within the team, optionally with a URL for team members with a well known format to have this handled by a dynamic external datasource if possible. (If not the consumer could write their own system to update the resources with the list of people/teams)

Additionally after this we should either be able to look up a team and get it's id via kubernetes resources, or where a team can be used today by id we should also accept a teamName, even if not fully in line with the grafana api, so that names and not ids that users do not have full control of can be used.

Describe alternatives you've considered
The only other way I can see to handle this is either the terraform module, or a custom application & helm deployment, neither of which are great.

Existing solutions
https://registry.terraform.io/providers/grafana/grafana/latest/docs/data-sources/team

notes

If this is accepted I am happy to contribute towards this but likely will need assistance as I have not worked in the operator space before

@xorima xorima added enhancement New feature or request needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 6, 2023
@NissesSenap
Copy link
Collaborator

NissesSenap commented Nov 19, 2023

@xorima i have spent lots and lots of time in this area. Yes the initial plan was org level support as well, but even managing teams, sa and users is a pain with CRDs. This is mostly due to how the grafana API is not built for CRDs (nothing strange with this).

I wrote a design PR on how this could look like and the more I learned about the API the less I thought it was double, in a easy to use CRD.
#615 please take a look at the Ideas I had back then.

For this feature to ever be implemented, you or someone else from the community will need to be the driver and a new design proposal on how the CRD should look like needs to be created.

After that, the implementation should be relatively easy to fix.

@NissesSenap NissesSenap added triage/needs-information Indicates an issue needs more information in order to work on it. and removed needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 19, 2023
@xorima
Copy link
Author

xorima commented Nov 25, 2023

@NissesSenap thank you will write up a full proposal.

I think this time it might be a little simpler as it's just creation of teams (which flows into folder permissions)

It might be worth leaving the population of the teams to another future issue as that is where a lot of complexity lives and honestly people will have different solutions there depending on their environment etc.

Copy link

This issue hasn't been updated for a while, marking as stale, please respond within the next 7 days to remove this label

@github-actions github-actions bot added the stale label Dec 26, 2023
@xorima
Copy link
Author

xorima commented Dec 26, 2023

Still creating a design for this will try to have it by early Jan

@github-actions github-actions bot removed the stale label Dec 27, 2023
Copy link

This issue hasn't been updated for a while, marking as stale, please respond within the next 7 days to remove this label

@github-actions github-actions bot added the stale label Jan 27, 2024
@xorima
Copy link
Author

xorima commented Jan 28, 2024

Keeping open. The plan is still to do this.

@NissesSenap NissesSenap added approved triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed triage/needs-information Indicates an issue needs more information in order to work on it. stale labels Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved enhancement New feature or request triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants