Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from grafonnet-lib to grafonnet #1288

Open
NissesSenap opened this issue Oct 24, 2023 · 2 comments
Open

Change from grafonnet-lib to grafonnet #1288

NissesSenap opened this issue Oct 24, 2023 · 2 comments
Labels
enhancement New feature or request feature-request requests a new feature that currently isn't implemented in the project help wanted Extra attention is needed triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@NissesSenap
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
grafonnet-lib has been archived, and we should go over to grafonnet instead.

Describe the solution you'd like
Ether that we support both grafonnet-lib and grafonnet for some time. But depending if grafonnet is backwards compatible or not, it would be nice to just change over to the new vrsion.

Describe alternatives you've considered
N/A

Additional context

#1279

@NissesSenap NissesSenap added enhancement New feature or request needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 24, 2023
@NissesSenap
Copy link
Collaborator Author

@olejeglejeg do you have any thoughts on this.
Have you any input on this one? What would be the impact of changing over to grafonnet from grafonnet-lib?

@NissesSenap NissesSenap added triage/accepted Indicates an issue or PR is ready to be actively worked on. help wanted Extra attention is needed feature-request requests a new feature that currently isn't implemented in the project and removed needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 24, 2023
@olejeglejeg
Copy link
Contributor

Hi @NissesSenap

It will be breaking change because libs have different contracts and it might significantly affect customers after upgrade.

It's not a smooth way, but currently, you can suggest clients provide new lib as a runtime build input, example here. Or operator needs to provide functionality to delegate managing libs set to the team that owns it, but it makes the operator logic of resources sync more complex.

P.S. The deprecation of grafionnet-lib was one of the factors why we suggested runtime builds since we use new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature-request requests a new feature that currently isn't implemented in the project help wanted Extra attention is needed triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants