Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade plugin dependencies to React 18 #205

Closed
idastambuk opened this issue Jul 25, 2023 · 2 comments · Fixed by #212
Closed

Upgrade plugin dependencies to React 18 #205

idastambuk opened this issue Jul 25, 2023 · 2 comments · Fixed by #212
Assignees
@idastambuk
Labels
datasource/TwinMaker effort/medium type/chore

Comments

@idastambuk
Copy link
Contributor

As of Grafana10, Twinmaker runs in Grafana's React18 environment, so we should update React dev dependencies to 18 as well.
Additionally, iot-app-kit with SceneViewer and VideoPlayer plugins have been upgraded to React18, so we should do this before we bump the versions.

The Grafana React 18 PR description could be useful to see what needs to be upgraded
@katebrenner
Copy link
Contributor

katebrenner commented Aug 1, 2023 •
edited

goal to have this by Aug 15. New deadline incoming

@idastambuk idastambuk self-assigned this Aug 2, 2023
@idastambuk
Copy link
Contributor Author

Right now, we're waiting for AWS components to be updated, so moving to Waiting

@fridgepoet fridgepoet mentioned this issue Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@idastambuk idastambuk

Labels
datasource/TwinMaker effort/medium type/chore
Projects
AWS Datasources
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade plugin dependencies to React 18 grafana/grafana-iot-twinmaker-app
3 participants
@idastambuk @taleena @katebrenner