Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection leak due to error reconnect #253

Closed
jkaflik opened this issue Dec 5, 2022 · 0 comments · Fixed by #257
Closed

Connection leak due to error reconnect #253

jkaflik opened this issue Dec 5, 2022 · 0 comments · Fixed by #257
Labels
type/bug Something isn't working

Comments

@jkaflik
Copy link
Collaborator

jkaflik commented Dec 5, 2022

Describe the bug

Versions
Grafana v9.2.6
ClickHouse datasource 2.0.4

Query
query agnostic issue. In fact, any invalid query leads us to this issue.

To Reproduce
Navigate to "Explore" and run a query that will fail and repeat this. (SELECT 1=1 FROM missing_table)
Meanwhile, see active connections metric growing (TCP in my case) with each failed query:

SELECT * FROM system.metrics WHERE metric = 'TCPConnection'

Shorthand URL: query

This is due grafana/sqlds does reconnect on any error, not followed with close on released connection.

Expected behavior
The connection is properly closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants