Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs feedback: /docs/sources/static/api/_index.md #4915

Open
ethirolle opened this issue Aug 24, 2023 · 3 comments
Open

Docs feedback: /docs/sources/static/api/_index.md #4915

ethirolle opened this issue Aug 24, 2023 · 3 comments
Labels
type/docs Docs Squad label across all Grafana Labs repos variant/static Related to Grafana Agent Static.

Comments

@ethirolle
Copy link

This page is missing any information on the /debug/pprof/... API endpoints.

In doc page https://grafana.com/docs/agent/latest/static/configuration/flags/#server, it is mentioned:

-server.register-instrumentation: Expose the /metrics and /debug/pprof/ instrumentation handlers over HTTP (default true)

And I can verify that at least /debug/pprof/heap and /debug/pprof/goroutine endpoints work... but I think there are other profile types available, as referenced in our doc section about Support Bundles:

The pprof/ directory contains Go runtime profiling data (CPU, heap, goroutine, mutex, block profiles) as exported by the pprof package.

Can we please add these API endpoints to this page? Thanks!

@rfratto rfratto added the type/docs Docs Squad label across all Grafana Labs repos label Aug 29, 2023
@rfratto
Copy link
Member

rfratto commented Aug 31, 2023

👋 I'm genuinely not sure if we'd consider the /debug/pprof endpoints as part of the "API;" they're not necessarily guaranteed to be stable since it comes directly from the Go project.

I'd personally like to consider these as something different than API endpoints (debugging endpoints, maybe?) where we don't provide any backwards compatibility guarantees, since we don't control the endpoints or their function.

cc @clayton-cornell for thoughts

@clayton-cornell
Copy link
Contributor

Mistakenly linked a PR to this issue.

@clayton-cornell
Copy link
Contributor

@rfratto What's the usecase for poking at these endpoints? Is it just for debugging? Could we list what's included and link out to the Go API for definitions/details?

@rfratto rfratto added the variant/static Related to Grafana Agent Static. label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Docs Squad label across all Grafana Labs repos variant/static Related to Grafana Agent Static.
Projects
No open projects
Development

No branches or pull requests

3 participants