Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visibility if scrape time > scrape interval #4789

Open
mattdurham opened this issue Aug 14, 2023 · 2 comments
Open

Add visibility if scrape time > scrape interval #4789

mattdurham opened this issue Aug 14, 2023 · 2 comments
Labels
enhancement New feature or request flow Related to Grafana Agent Flow postmortem variant/static Related to Grafana Agent Static.

Comments

@mattdurham
Copy link
Collaborator

Request

In flow the scrape component should mark itself as unhealthy if the scrape interval > scrape length. Or some other obvious alerting.

Use case

Need more visibility into unhealthiness.

@mattdurham mattdurham added enhancement New feature or request type/core flow Related to Grafana Agent Flow labels Aug 14, 2023
@rfratto
Copy link
Member

rfratto commented Aug 15, 2023

Historical context:

This is part of an overall debate for if the health of prometheus.scrape should depend on the scrape targets.

This was something we discussed early on, and the initial decision was no: just because a target collected by prometheus.scrape is unhealthy/timing out doesn't mean that prometheus.scrape itself is misbehaving.

We could revisit that decision, or we could find other ways to surface the problem as a metric/log/trace/etc.

@github-actions
Copy link
Contributor

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@github-actions github-actions bot added the needs-attention An issue or PR has been sitting around and needs attention. label Sep 15, 2023
@rfratto rfratto removed the type/core label Nov 2, 2023
@rfratto rfratto added the variant/static Related to Grafana Agent Static. label Apr 9, 2024
@github-actions github-actions bot removed the needs-attention An issue or PR has been sitting around and needs attention. label Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request flow Related to Grafana Agent Flow postmortem variant/static Related to Grafana Agent Static.
Projects
No open projects
Development

No branches or pull requests

3 participants