Managed workloads are not compatible with kubectl rollout restart

[alex-berger]

What's wrong?

Workloads (Deployment, StatefulSet, DaemonSet) owned and managed by the grafana agent operator do not work well with kubectl rollout restart .... This is because kubectl rollout restart works by setting annotation kubectl.kubernetes.io/restartedAt in .spec.template.metadata.annotations, but the grafana agent operator will immediately remove that annotation again and thus interrupt/stop th rollout.

The offending (missing) code is at

• https://github.com/grafana/agent/blob/v0.34.3/pkg/operator/clientutil/clientutil.go#L138
• https://github.com/grafana/agent/blob/v0.34.3/pkg/operator/clientutil/clientutil.go#L183
• https://github.com/grafana/agent/blob/v0.34.3/pkg/operator/clientutil/clientutil.go#L224

A possible fix could be to merge .spec.template.metadata.annotations (and maybe also .spec.template.metadata.labels) similar to what is already done for .metadata.annotations and .metadata.labels.

Steps to reproduce

This can be reproduced by restarting any workload managed by the grafana agent operator using kubectl rollout restart ....

System information

No response

Software version

No response

Configuration

No response

Logs

No response

[github-actions]

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!