Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to constants.go on master branch #836

Merged
merged 2 commits into from Oct 18, 2022
Merged

Conversation

arve0
Copy link
Contributor

@arve0 arve0 commented Oct 17, 2022

Got confused constants.go had no changes since last summer. Line number is unlikely to change (has not in a year).

Description

Relevant issues/tickets

Type of change

  • Documentation improvement
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

Check that link works and that file is updated last year.

Got confused constants.go had no changes since last summer. Line number is unlikely to change (has not in a year).
@NissesSenap NissesSenap merged commit 4d95c6c into grafana:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants