Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore case for folder names in grafana responses #830

Merged
merged 1 commit into from Oct 5, 2022

Conversation

weisdd
Copy link
Collaborator

@weisdd weisdd commented Oct 4, 2022

Description

As it turned out in #829, grafana is case-insensitive for folder names. Thus, the suggestion is to ignore the case in functions that try to find an already-existing folder.

Relevant issues/tickets

#829

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

  1. Deploy two dashboards with the same folder names written in different case (e.g. platform and Platform)
    => Both dashboards should appear in grafana interface, no logs with the 409 code in operator logs.

Copy link
Collaborator

@NissesSenap NissesSenap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants