Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #762 #765

Merged
merged 2 commits into from May 31, 2022
Merged

fix #762 #765

merged 2 commits into from May 31, 2022

Conversation

HubertStefanski
Copy link
Collaborator

Description

Relevant issues/tickets

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

@HubertStefanski
Copy link
Collaborator Author

@NissesSenap You mentioned this you used the proper flag, right? It should be --zap-log-level as with this change right?

NissesSenap
NissesSenap approved these changes May 25, 2022
View reviewed changes
Copy link
Collaborator

@NissesSenap NissesSenap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NissesSenap NissesSenap merged commit 1a75ad9 into master May 31, 2022
@NissesSenap NissesSenap deleted the update-docs-25-may branch May 31, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NissesSenap NissesSenap NissesSenap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HubertStefanski @NissesSenap