New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nil check for service & service ports before iterating #748

Merged

NissesSenap merged 2 commits into grafana:master from jacobsee:fix-segfault-issue-746

May 8, 2022

Contributor

jacobsee commented May 7, 2022

Description

Simple fix: add a nil check for service & service ports before iterating in GetServicePorts

Relevant issues/tickets

Type of change

Bug fix (non-breaking change which fixes an issue)

Checklist

This change requires a documentation update
I have added tests that prove my fix is effective or that my feature works
I have added a test case that will be used to verify my changes
Verified independently on a cluster by reviewer

Verification steps

jacobsee added 2 commits

May 6, 2022 21:23


          Add nil check for service & service ports before iterating

230cd6e


          Actually, second check was unnecessary.

47c6963

NissesSenap approved these changes

View reviewed changes

NissesSenap merged commit a1245e3 into grafana:master

Collaborator

NissesSenap commented May 8, 2022

Thanks for the quick action @jacobsee
LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment