Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Topology Spread Constraints to Grafana CR #839

Merged

Conversation

celestialorb
Copy link
Contributor

Description

Adds specification of topology spread constraints to a managed Grafana deployment.

Relevant issues/tickets

Closes #834.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

  1. With the Grafana operator running against a cluster, add a Grafana CR without TopologySpreadConstraints defined in the deployment specification.
  2. Ensure the resultant Grafana deployment contains no topology spread constraints.
  3. Specify a Grafana CR with some arbitrary TopologySpreadConstraints defined.
  4. Ensure the resultant Grafana deployment contains the same topology spread constraints.

@NissesSenap
Copy link
Collaborator

Sorry for the slow reply @celestialorb , I will fix the CI issues in your PR. Other then that I think everything looks good :)

@NissesSenap NissesSenap force-pushed the feature/topology-spread-constraints branch from 3bf0868 to 4ee4648 Compare November 17, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Specification for Topology Spread Constraints
2 participants