Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to set datasource timeout #826

Merged
merged 2 commits into from Sep 27, 2022

Conversation

alex-berger
Copy link
Contributor

This addition allows setting the data-source HTTP client timeout, to work around situations where the default timeout is to small.

Note, I choose the type int for the timeout as this is what the Grafana code primarily expects, technically string or intstr.IntOrString would also work.

Signed-off-by: Alexander Berger alex.berger@nexxiot.com

Description

Relevant issues/tickets

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • This change requires a documentation update
  • I have added tests that prove my fix is effective or that my feature works
  • I have added a test case that will be used to verify my changes
  • Verified independently on a cluster by reviewer

Verification steps

Signed-off-by: Alexander Berger <alex.berger@nexxiot.com>
@NissesSenap NissesSenap mentioned this pull request Sep 27, 2022
7 tasks
Copy link
Collaborator

@pb82 pb82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pb82 pb82 merged commit 54a5592 into grafana:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants