fix: use non-fqdn url for grafana to support non-standard cluster names #791
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, grafana-operator uses FQDN names for its calls to grafana API (e.g.
http://grafana.monitoring.svc.cluster.local:3000
), which is incompatible with custom cluster names.For internal DNS requests, there's no need to rely on FQDN,
<svc-name>.<namespace>:<port>
format is perfectly fine.The PR addresses that.
Additional changes:
gofumpt
;Relevant issues/tickets
Fixes: #592
Type of change
Checklist
Verification steps