New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to provide compressed JSON for large dashboards #767
Conversation
* Added fields gzipJson and gzipConfigMapRef to GrafanaDashboardSpec * Added unit tests for decoding/decompression * Added docs explaining how to compress dashboard data * Added example compressed dashboards to verify functionality
ab9c232
to
a352f0a
Compare
a352f0a
to
04bdf2b
Compare
@meln5674 thanks for the PR. The reason why the CI failes is due to that you are using go >=1.17. Feel free to wait for that to get merged or you can just remove the update that you did with: --- a/api/integreatly/v1alpha1/zz_generated.deepcopy.go
+++ b/api/integreatly/v1alpha1/zz_generated.deepcopy.go
@@ -1,4 +1,3 @@
-//go:build !ignore_autogenerated
// +build !ignore_autogenerated About the markdown errors please have a look at them. |
It turns out that's actually not because of the go version, but it seems to be getting auto-injected by vim every time I save. I can just remove it by hand in another editor. As for the markdown linter, unless I'm misinterpreting the output, none of those are lines I touched:
So I'm not entirely sure what the issue is. |
@meln5674 it got something to do with your go version. I'm 99% sure because I have the same thing. Even if I don't touch that file when I run all the generate commands it will apply the exact same config. So for the last year I have removed this change manually every time ^^. You can also take a look at my PR and I have added the change that is happening but since I have upgrade to 1.18 in the CI it now passes. |
Even thgouh this file wast updated in this PR orignially I fix it here to pass the CI.
About the CI linter, I have no idea why it changed, my guess would be that the underlying dockerfile have been updated even though I used a tagged version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice job, tests, fixing docs and providing examples straight out of the box :).
Added a few comments for some extra CRD documentation.
Other then that I think it looks good.
@HubertStefanski @pb82 any thoughts?
…n5674/grafana-operator into feature/grafana-operator-726
Hey, just wanted to check in on this. I see there's been some merges from master into this, and the CI is complaining about something unrelated. Is this just a result of some CI changes you guys are in the middle of, or is there action required on my part? |
@meln5674 if you have the time it would be great if you can fix the lint issues just to make the CI happy. Another option is just to ignore them. |
I did a grep for the |
I will have a look at it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified, thanks @meln5674
Description
Relevant issues/tickets
Fixes #726
Type of change
Checklist
Verification steps
Tested locally via the following