New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track dashboards per namespace in ControllerConfig #690
Track dashboards per namespace in ControllerConfig #690
Conversation
hey @addreas Can you verify that manifests/crds generate correctly for this type? AFAIR we had a few issues with generation because of the custom type in the map. However, if that works now, we're more than happy to revert to the mapped approach |
4ffc730
to
0694317
Compare
Hmm, not sure I follow. Isn't this type internal to the controller? I can't see this type used in anything generated, Pushed a fix for the formatting to make go-lint happy. |
Thanks @addreas I'll take a look at this again today and verify it locally, then we can merge this! |
@addreas I've had a chance to look through, Code looks good, however, the Grafana CR status isn't being updated with the references, as I think you intended for it to do. Currently this looks like it's stored in memory (which is fine as long as the operator pod is up and running) |
Good catch, @HubertStefanski, didn't think of checking if that still worked before. Looking at my changes now I see how I might have stopped at making the compiler happy without actually thinking about what the code was intended to do. Taking a look at fixing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@addreas sorry for being soo slow with this, I verified it on my openshift cluster, works beautifully 👍
Description
I was having issues with dashboards getting re-fetched and the grafana instance restarting constantly, and eventually I tracked it down to this being the root cause.
Relevant issues/tickets
Without digging too deep I see that #686 seems similar to the issues I was facing.
Type of change
Checklist
Verification steps
Has been running in my home cluster for a while, and the issues have vanished, so it seems I did something right. Another pair of eyes never hurt though.