Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace NodeJS v12 with NodeJS v16 #53

Merged
merged 3 commits into from Dec 23, 2021
Merged

Conversation

KengoTODA
Copy link
Contributor

@KengoTODA KengoTODA commented Dec 21, 2021

This action uses NodeJS v12 (Erbium) for now, which will end its support next April.

According to actions/runner#772 now GitHub Actions can run on NodeJS v16 (Gallium). So this PR suggests migrating to NodeJS v16. It also contains several related changes:

Note that this action has already run its test on NodeJS v16 from this Dec/10th. So I believe that the feature won't be broken by this NodeJS upgrade.

Thanks for checking my PR! 馃憢

@JLLeitschuh
Copy link
Contributor

@KengoTODA Thank you very much for your contribution here! Your PR actually inspired me to add some additional checks to our pipeline. Your contribution includes quite a few changes that are difficult to review as the changes are made to generated code. As such, I introduced an additional CI check to verify your changes and the generated code line-up.

https://github.com/gradle/wrapper-validation-action/blob/master/.github/workflows/check-dist.yml

Could you do me a favor and rebase your changes so those new checks are executed? 馃槂

@JLLeitschuh
Copy link
Contributor

Also, you'll probably need to update this after rebasing:

- name: Set Node.js 12.x
uses: actions/setup-node@v2.4.1
with:
node-version: 12.x

Copy link
Contributor

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants