Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify distributionUrl and distributionSha256Sum in gradle-wrapper.properties against the official list #35

Open
vlsi opened this issue Mar 17, 2021 · 4 comments
Open

Verify distributionUrl and distributionSha256Sum in gradle-wrapper.properties against the official list #35

vlsi opened this issue Mar 17, 2021 · 4 comments

Comments

@vlsi
Copy link

vlsi commented Mar 17, 2021 •
edited

Validate gradle/wrapper/gradle-wrapper.properties:

  1. Assume distributionUrl points to a canonical Gradle location. If the link is not listed in https://services.gradle.org/versions/all, then fail the validation.
  2. For those who want a customized Gradle distribution, add skip-distribution-validation: true|false configuration option (default: false)
  3. Enforce the valid distributionSha256Sum for the official distributions
@vlsi vlsi mentioned this issue Mar 17, 2021
Open
@JLLeitschuh
Copy link
Contributor

I could get behind this feature. @eskatos what are your thoughts?

@eskatos
Copy link
Member

eskatos commented Mar 19, 2021

This indeed sounds like a good idea

@JLLeitschuh
Copy link
Contributor

@vlsi would you be willing to contribute a PR?

@vlsi
Copy link
Author

vlsi commented Mar 19, 2021

I'm afraid it would take me a while (I'm not much into TypeScript)

@vlsi vlsi mentioned this issue May 13, 2021
Open
mikepenz added a commit to mikepenz/wrapper-validation-action that referenced this issue Aug 24, 2023
@mikepenz
- introduce new configuration to enable checksum validation only for …
c7f33a0 
…detected versions

  - version is detected from `gradle-wrapper.properties`
  - checksum is only fetched for these particular versions
- FIX gradle#96

While not specifically targeted, this also
- RESOLVES gradle#142

May enable gradle#35
@mikepenz mikepenz mentioned this issue Aug 24, 2023
Open
mikepenz added a commit to mikepenz/wrapper-validation-action that referenced this issue Jan 25, 2024
@mikepenz
- introduce new configuration to enable checksum validation only for …
1f0a388 
…detected versions

  - version is detected from `gradle-wrapper.properties`
  - checksum is only fetched for these particular versions
- FIX gradle#96

While not specifically targeted, this also
- RESOLVES gradle#142

May enable gradle#35
mikepenz added a commit to mikepenz/wrapper-validation-action that referenced this issue Jan 30, 2024
@mikepenz
- introduce new configuration to enable checksum validation only for …
f8ea516 
…detected versions

  - version is detected from `gradle-wrapper.properties`
  - checksum is only fetched for these particular versions
- FIX gradle#96

While not specifically targeted, this also
- RESOLVES gradle#142

May enable gradle#35
mikepenz added a commit to mikepenz/wrapper-validation-action that referenced this issue Jan 30, 2024
@mikepenz
- introduce new configuration to enable checksum validation only for …
54f0bdf 
…detected versions

  - version is detected from `gradle-wrapper.properties`
  - checksum is only fetched for these particular versions
- FIX gradle#96

While not specifically targeted, this also
- RESOLVES gradle#142

May enable gradle#35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eskatos @vlsi @JLLeitschuh