Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output against which version of a wrapper JAR validation succeeded #23

Open
sschuberth opened this issue Mar 30, 2020 · 6 comments
Open
Labels
enhancement New feature or request

Comments

@sschuberth
Copy link
Contributor

In addition to know that a wrapper JAR successfully validated, it would also be nice to see in the console output which version was actually found to be a match.

@JLLeitschuh
Copy link
Contributor

@sschuberth We are now intentionally attempting to minimize changes to the gradle-wrapper.jar file between releases. As such, there are now versions of the gradle-wrapper.jar that match multiple releases because the SHA-256 checksum won't have changed.

@JLLeitschuh JLLeitschuh added the question Further information is requested label Mar 30, 2020
@sschuberth
Copy link
Contributor Author

I see. Would it still make sense to output the most recent Gradle version the wrapper currently matches for?

@JLLeitschuh
Copy link
Contributor

Theoretically, we could output a range of version matches. @eskatos what do you think?

@sschuberth what need are you looking to satisfy?

@sschuberth
Copy link
Contributor Author

@sschuberth what need are you looking to satisfy?

I'm looking for some indication whether committed wrapper JARs might be outdated WRT the latest version available. If my committed wrapper JAR is the one from, say, Gradle 4.6, but my gradle-wrapper.properties points at Gradle 6.3, then it's quite likely that the wrapper JAR has been updated in between, and I might want to update it.

The background is that probably not many users are aware that running the wrapper task (once) does not update the wrapper JAR. Also see my PR gradle/gradle#12671.

@JLLeitschuh
Copy link
Contributor

That makes sense.

Somewhat outside the scope of this project, but I can see why that would be useful.

I'm happy to review a PR that adds this functionality if you want to contribute something.

@JLLeitschuh JLLeitschuh added enhancement New feature or request and removed question Further information is requested labels Mar 30, 2020
@sschuberth
Copy link
Contributor Author

I'm happy to review a PR that adds this functionality if you want to contribute something.

I don't think I'll ever find the time to implement this due to my non-existing TypeScript skills. So, should we close this, or leave it open for some one else to work on eventually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants
@sschuberth @JLLeitschuh and others