Skip to content
This repository has been archived by the owner on Aug 19, 2020. It is now read-only.

Committed Gradle wrappers do not validate with the official GitHub Action #1398

Closed
sschuberth opened this issue Mar 30, 2020 · 4 comments
Closed
Assignees

Comments

@sschuberth
Copy link

Expected Behavior

All gradle-wrapper.jar files commit to this repository, e.g. kotlin-dsl-samples/samples/multi-kotlin-project/gradle/wrapper/gradle-wrapper.jar, should validate with the official GitHub Action, see https://blog.gradle.org/gradle-wrapper-checksum-verification-github-action.

Current Behavior

At least kotlin-dsl-samples/samples/multi-kotlin-project/gradle/wrapper/gradle-wrapper.jar does not pass validation.

Context

We are using multi-kotlin-project as a Git submodule in a project that uses the GitHub Action to validate all Gradle wrappers.

I'm not sure whether the fix is to update the wrapper JARs, or to add their SHA-256 hashes as valid, but in any case I'd appreciate if this could be fixed.

@sschuberth
Copy link
Author

or to add their SHA-256 hashes as valid

That probably depends on gradle/wrapper-validation-action#8.

@JLLeitschuh
Copy link
Contributor

I'm guessing that you are probably right. @eskatos @bamboo, can we transition our samples in that repository to always use non-snapshot versions, or is it not a safe assumption that we won't ever use snapshot versions in that repository?

@eskatos eskatos self-assigned this Mar 31, 2020
@eskatos
Copy link
Member

eskatos commented Mar 31, 2020

Yes. PR updating the wrappers and adding the wrapper validation action #1399

@eskatos
Copy link
Member

eskatos commented Mar 31, 2020

PR merged, closing

@eskatos eskatos closed this as completed Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants