-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration Cache does not persist int
#16657
Comments
Meanwhile - thank to @C-Otto - I saw https://github.com/gradle/gradle/pull/14628/files#diff-239c622f1af32f1bee008aa813579ded9fffeb072f25557cf8eb27801268c770 where you changed On the other side would supporting |
Hi @aaschmid, could you confirm the latest Gradle version you have been able to reproduce this issue with? |
On the using side of the plugin I had the problem with 6.6, 6.7, and 7.0-RC1. On the building side - does that matter? - I used 6.6 only. Should I test something in addition? |
Thanks, @aaschmid. The building side shouldn't matter. At first I cannot reproduce the problem with a simple test case so I wonder what else might be different in your plugin's case. Possibly the interaction with convention mapping setup by CpdPlugin. Let's see. |
Thanks for the update and your reproducer seems fine. But can you reproduce it with my reproducer? |
Yes, I can reproduce the test failure you described. |
On my gradle-cpd-plugin I have a task property named
minimumTokenCount
which was of typeint
. Besides an other issue with newconfiguration-cache
I get> Task 'cpdCheck' requires 'minimumTokenCount' to be greater than zero.
on the second run if I useint
for theminimumTokenCount
@Input
property. Changing this toInteger
makes the reproducer test case green again.Expected Behavior
I would except that
int
property could be configuration cached asboolean
s does as well. Haven't found any documentation that it should not work.Current Behavior
int
properties cannot be used withconfiguration-cache
.Context
I try to enable my plugin to be usable with
--configuration-cache
, as requested in aaschmid/gradle-cpd-plugin#54.Steps to Reproduce
git clone git@github.com:aaschmid/gradle-cpd-plugin.git
git checkout reproduce.config.cache.problem.on.int
./gradlew integTest --tests "de.aaschmid.gradle.plugins.cpd.test.CpdAcceptanceTest.Cpd task can be loaded from the configuration cache"
> Task 'cpdCheck' requires 'minimumTokenCount' to be greater than zero.
on standard output of test resultsInteger
bygit revert 0851999
Your Environment
The text was updated successfully, but these errors were encountered: