Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix repository not downloaded from Maven Central #374

Merged
merged 1 commit into from Nov 28, 2022
Merged

Fix repository not downloaded from Maven Central #374

merged 1 commit into from Nov 28, 2022

Conversation

melix
Copy link
Collaborator

@melix melix commented Nov 25, 2022

Fixes #373

@melix melix added bug Something isn't working gradle-plugin Related to Gradle plugin labels Nov 25, 2022
@melix melix added this to the 0.9.19 milestone Nov 25, 2022
@melix melix requested a review from sdeleuze November 25, 2022 15:06
@melix melix self-assigned this Nov 25, 2022
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 25, 2022
sdeleuze
sdeleuze reviewed Nov 28, 2022
View reviewed changes
Copy link
Collaborator

@sdeleuze sdeleuze left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Maven plugin downloads metadata from Maven Central already?

@melix
Copy link
Collaborator Author

melix commented Nov 28, 2022

Does Maven plugin downloads metadata from Maven Central already?

It does:

native-build-tools/native-maven-plugin/src/main/java/org/graalvm/buildtools/maven/AbstractNativeMojo.java

Lines 208 to 217 in 51baf9f

Dependency repository = new Dependency(new DefaultArtifact(
GROUP_ID,
GRAALVM_REACHABILITY_METADATA_ARTIFACT_ID,
"repository",
REPOSITORY_FORMAT,
VersionInfo.NBT_VERSION
), "runtime");
collectRequest.addDependency(
repository
);

@melix melix merged commit 750007a into master Nov 28, 2022
@melix melix deleted the cc/issue-373 branch November 28, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdeleuze sdeleuze sdeleuze left review comments

Assignees

@melix melix

Labels
bug Something isn't working gradle-plugin Related to Gradle plugin OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
0.9.19
Development

Successfully merging this pull request may close these issues.

Default metadata repository isn't downloaded from Maven Central
2 participants
@melix @sdeleuze