Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looser tslib dependency #385

Closed
wSedlacek opened this issue Nov 25, 2021 · 6 comments
Closed

Looser tslib dependency #385

wSedlacek opened this issue Nov 25, 2021 · 6 comments

Comments

@wSedlacek
Copy link
Collaborator

"tslib": "^2.3.1"

RxJS is still using tslib ~2.1.0, it would be nice to match that version.

@gperdomor
Copy link
Owner

@wSedlacek in fact I think I can remove that dependency 🤔 ...

Did you have an issue related to this?

@wSedlacek
Copy link
Collaborator Author

It didn't cause any errors, however due to the version conflict I had two versions of tslib installed in my project.
Not a big deal, but it would be nice to have versions matching

Here is the issue on the rxjs side
ReactiveX/rxjs#6689

@wSedlacek
Copy link
Collaborator Author

wSedlacek commented Nov 26, 2021

@wSedlacek in fact I think I can remove that dependency 🤔 ...

Before you remove it I would recommend checking to see that you have the importHelpers configured such that your compiled code does not require tslib.

https://www.typescriptlang.org/tsconfig#importHelpers

"importHelpers": true,

From what I understand TypeScript 4.4 does need tslib 2.3.0+ if you have importHelpers set to true
(See the issue that was closed on ng-packgr)

@gperdomor
Copy link
Owner

I set all packages to use ^2.1.0

@gperdomor
Copy link
Owner

I will close this now... 😄

@wSedlacek
Copy link
Collaborator Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants