Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 4 breaks font-awesome-webpack... #41

Open
jarecsni opened this issue Mar 25, 2018 · 16 comments
Open

Webpack 4 breaks font-awesome-webpack... #41

jarecsni opened this issue Mar 25, 2018 · 16 comments

Comments

@jarecsni
Copy link

Due to this module depending on an old version of less-loader.

Does anyone know of a fork supporting webpack 4 as this project seems to be defunct?

@jarecsni
Copy link
Author

I forked this project and updated the dependencies, which solved the build problem. Not sure if it makes sense to raise a PR here.

@komali2
Copy link

komali2 commented Apr 12, 2018

why did i become a web developer

why

@thescientist13
Copy link

thescientist13 commented Apr 17, 2018

@jarecsni , thanks for making that fork!

I tested it out using

$ yarn add font-awesome-webpack@https://github.com/jarecsni/font-awesome-webpack#440af2a2efe7ba1779d039556f04538e57bad4bb --dev

and all is working for me. I think you should make a PR for the dependency upgrade, IMO. 👍

@JoelParke
Copy link

I too have tested it out as above. And it is working fine. So If you can make a PR, that would be great!

@JoelParke
Copy link

@jarecsni I think a pull request would be good.

@nstrelow
Copy link

nstrelow commented Jul 5, 2018

@jarecsni Please make a PR, this would be very helpful to people still using this.

Are there alternatives?

@eregnier
Copy link

I forked @jarecsni fork to do the PR : #42
wait & see.

@thescientist13
Copy link

thanks @eregnier !

@bparticle
Copy link

Any pointers on how to obtain the patch or fork to make font-awesome work with webpack 4 right now? I'm not yet quite up to speed with the flow of things around here I'm afraid :(

@eregnier
Copy link

@bparticle you can install @jarecsni fork with up to date version using something like

npm i git@github.com:jarecsni/font-awesome-webpack.git

until I hope his fork is merged to the upstream repository.

@bparticle
Copy link

bparticle commented Jul 24, 2018

@eregnier Thanks for your answer. I'm getting this error, even though the repository does contain a package.json file:
Could not install from "github.com:jarecsni/font-awesome-webpack.git" as it does not contain a package.json file.

@eregnier
Copy link

indeed, there is an issue with npm and git URI.

instead, try :

npm i https://github.com/jarecsni/font-awesome-webpack.git

I tried it this time and it works for me.

@tapz
Copy link

tapz commented Aug 15, 2018

My fork:

https://www.npmjs.com/package/font-awesome-webpack-4

"font-awesome-webpack-4": "1.0.0",

@thescientist13
Copy link

thank you @tapz 🙏

Will give it a try and let you know!

@JoelParke
Copy link

Awesome @tapz -- I am not using this directly and have removed my fork!

@JamesTheHacker
Copy link

A SASS version would be beautiful.

@eregnier eregnier mentioned this issue Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants