-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack 4 breaks font-awesome-webpack... #41
Comments
I forked this project and updated the dependencies, which solved the build problem. Not sure if it makes sense to raise a PR here. |
why did i become a web developer why |
@jarecsni , thanks for making that fork! I tested it out using $ yarn add font-awesome-webpack@https://github.com/jarecsni/font-awesome-webpack#440af2a2efe7ba1779d039556f04538e57bad4bb --dev and all is working for me. I think you should make a PR for the dependency upgrade, IMO. 👍 |
I too have tested it out as above. And it is working fine. So If you can make a PR, that would be great! |
@jarecsni I think a pull request would be good. |
@jarecsni Please make a PR, this would be very helpful to people still using this. Are there alternatives? |
thanks @eregnier ! |
Any pointers on how to obtain the patch or fork to make font-awesome work with webpack 4 right now? I'm not yet quite up to speed with the flow of things around here I'm afraid :( |
@bparticle you can install @jarecsni fork with up to date version using something like
until I hope his fork is merged to the upstream repository. |
@eregnier Thanks for your answer. I'm getting this error, even though the repository does contain a package.json file: |
indeed, there is an issue with npm and git URI. instead, try :
I tried it this time and it works for me. |
My fork: https://www.npmjs.com/package/font-awesome-webpack-4 "font-awesome-webpack-4": "1.0.0", |
thank you @tapz 🙏 Will give it a try and let you know! |
Awesome @tapz -- I am not using this directly and have removed my fork! |
A SASS version would be beautiful. |
Due to this module depending on an old version of less-loader.
Does anyone know of a fork supporting webpack 4 as this project seems to be defunct?
The text was updated successfully, but these errors were encountered: