Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Performance issues with sass #72

Closed
alex-page opened this issue Jul 5, 2018 · 1 comment
Closed

Performance issues with sass #72

alex-page opened this issue Jul 5, 2018 · 1 comment
Assignees
Labels
enhancement New feature or request.

Comments

@alex-page
Copy link
Contributor

alex-page commented Jul 5, 2018

It has been noted that there are obvious performance differences between sass and node-sass. According to the sass-dart repository these issues shouldn't exist however replacing sass with node-sass see's huge performance improvements.

    "build:sass": "sass pancake/sass/pancake.scss sass/style.css --style compressed",
    "build:node-sass": "node-sass pancake/sass/pancake.scss sass/style.css --style compressed",

screen shot 2018-07-05 at 1 12 38 pm

We originally moved to sass to fix corrupt dependencies. node-sass is nearly patched just waiting on node-gyp.

@alex-page alex-page changed the title Performance issues with sass Performance issues with sass Jul 5, 2018
@alex-page alex-page self-assigned this Jul 5, 2018
@alex-page alex-page added the enhancement New feature or request. label Jul 5, 2018
@pattyde pattyde added this to 🌱 Backlog in Design System Jul 5, 2018
@alex-page
Copy link
Contributor Author

alex-page commented Jul 13, 2018

This is waiting for nodejs/node-gyp#1492 or nodejs/node-gyp#1471

@alex-page alex-page moved this from 🌱 Product Backlog to ✏️ Sprint backlog in Design System Jul 19, 2018
@alex-page alex-page moved this from ✏️ Sprint backlog to 🏗 Doing in Design System Jul 19, 2018
@alex-page alex-page moved this from 🏗 Doing to ✏️ Sprint backlog in Design System Jul 23, 2018
@pattyde pattyde moved this from ✏️ Sprint backlog to 🌱 Product Backlog in Design System Aug 2, 2018
Design System automation moved this from 🌱 Product Backlog to ✨ Done Aug 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request.
Projects
Design System
  
✨ Done
Development

No branches or pull requests

1 participant