Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Header react module renders <div> instead of <header> #898

Open
3 tasks done
takumi-ae86 opened this issue Feb 20, 2020 · 0 comments
Open
3 tasks done

Header react module renders <div> instead of <header> #898

takumi-ae86 opened this issue Feb 20, 2020 · 0 comments

Comments

@takumi-ae86
Copy link

Bug Report

  • I’ve read and understood the Contributing guidelines and have done my best effort to follow them.
  • I’ve read and agree to the Code of Conduct.
  • I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

When using the AU header react component the it appears to render a <div class="au_header">

What I expected to happen

From the example in the documentation we expect it would have render a <header class="au_header"> element

Reproducing

  • Module name: @gov.au/header
  • Module version: 4.1.12
  • Pancake version: ~1 (As used by the header component)
"dependencies": {
    "@gov.au/core": "^3.0.0",
    "@gov.au/pancake": "~1",
    "@gov.au/pancake-json": "~1",
    "@gov.au/pancake-react": "~1",
    "@gov.au/pancake-sass": "~2"
  },
  • Node version: v12.13.1

  • npm version: 6.12.1

  • Pancake settings in your package.json:

Steps to reproduce:

  1. Compare the difference between static and react rendering of header component here
    https://auds.service.gov.au/packages/header/tests/react/
    https://auds.service.gov.au/packages/header/tests/site/

Attachments

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant