Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Pancake generated React components can not be used natively in Create React App #896

Open
3 tasks done
wibily opened this issue Jan 3, 2020 · 2 comments
Open
3 tasks done
Assignees
Labels
🐛 bug Something isn’t working the way it should.

Comments

@wibily
Copy link

wibily commented Jan 3, 2020

Bug Report

  • I’ve read and understood the Contributing guidelines and have done my best effort to follow them.
  • I’ve read and agree to the Code of Conduct.
  • I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

Create React App is the easiest way to bootstrap a new React project with sensible defaults. ESLint automatically runs in this configuration with rules defined in the ESLint config react app repository.

Now if i wanted to use the pancake generated Design System components inside my create-react-app bootstrapped project, the pancake generated React code will need to be ESlint compliant.

What I expected to happen

I expect the pancake generated React components to work natively in my create react app bootstrapped project

Reproducing

Steps to reproduce:

  1. Create a new create-react-app project. Instructions here
  2. Run npm install for all the Design system components
  3. Configure the pancake react to generated the components in my src/ directory so that i can reference them in my create-react-app project
  4. Import all the pancake react components in my index.js file
  5. Run npm start in my create react app project
  6. Observe that eslint errors prevent the project from starting.

Attachments

Reproduction repo here

@wibily wibily mentioned this issue Jan 3, 2020
@svict4
Copy link

svict4 commented Jun 12, 2020

There was an attempted previously: https://github.com/govau/design-system-starter-react

@svict4
Copy link

svict4 commented Jun 12, 2020

Also noteworthy that there are a few Government projects using the designsystem in Gatsby

@mrrossmullen mrrossmullen self-assigned this Feb 25, 2021
@mrrossmullen mrrossmullen added the 🐛 bug Something isn’t working the way it should. label Feb 25, 2021
@mrrossmullen mrrossmullen added this to 🌱 Product Backlog in Design System via automation Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Something isn’t working the way it should.
Projects
Design System
  
🌱 Product Backlog
Development

No branches or pull requests

3 participants