Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

AU-space not calculating correct REM if $AU-rem has been changed #883

Open
mikey0000 opened this issue Sep 9, 2019 · 1 comment
Open
Labels
🐛 bug Something isn’t working the way it should.

Comments

@mikey0000
Copy link

mikey0000 commented Sep 9, 2019

Bug Report

  • [ x] I’ve read and understood the Contributing guidelines and have done my best effort to follow them.
  • [ x] I’ve read and agree to the Code of Conduct.
  • [x ] I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

Set $AU-rem to 14, select box height gets set to
AU-space('height', 2.5unit)
height: 40px
height: 2.5rem

What I expected to happen

Set $AU-rem to 14, select box height gets set to
AU-space('height', 2.5unit)
height: 40px
height: 2.875rem

Reproducing

  • Module name: Select
  • Module version: latest
  • Pancake version:N/A
  • Node version:N/A
  • npm version:N/A
  • Pancake settings in your package.json:

Steps to reproduce:

  1. Set $AU-rem: 14;
  2. Run the test suite for Select
  3. select the HTML version and set HTML font-size: 14px
  4. view REM vs Height in inspector

It looks that the AU-space function doesn't take into account the $AU-rem setting.

Attachments

@KiriHoy KiriHoy added this to 🌱 Product Backlog in Design System via automation Sep 10, 2019
@KiriHoy
Copy link
Contributor

KiriHoy commented Sep 10, 2019

Hi @mikey0000 thanks for raising the issue! The team will have a look into it and get back to you

@gordongrace gordongrace added the 🐛 bug Something isn’t working the way it should. label Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 bug Something isn’t working the way it should.
Projects
Design System
  
🌱 Product Backlog
Development

No branches or pull requests

3 participants