Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github-actions and buildkite formats #316

Open
dnephin opened this issue Mar 29, 2023 · 4 comments
Open

Add github-actions and buildkite formats #316

dnephin opened this issue Mar 29, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@dnephin
Copy link
Member

dnephin commented Mar 29, 2023

Github actions supports grouping log lines.

Buildkite supports managing log output.

Gitlab CI supports collapsed sections.

Teamcity support: #316 (comment)

These allow some log output to be collapsed (hidden), and expanded by clicking on an arrow. gotestsum could use these features to provide better output when tests on run on these systems.

See #312 (comment) for some discussion about a buildkite format, and #315 for a first draft of the github actions format.

Some options for these formats:

  1. A format similar to the current testname format. Each test would be a group, and expanding the group would show the full output of the test. Currently only failed tests have output, but it wouldn't be too difficult to change to all tests having output hidden by the group.
  2. A format similar to the current pkgname format. Each package would be a group, and expanding the group would show the full list of tests in that package, or maybe only the failed test output.
@dnephin
Copy link
Member Author

dnephin commented Mar 29, 2023

I haven't been able to find similar features in other CI systems, but if anyone knows of similar features please do leave a comment with a link to the docs!

@Pawka
Copy link
Contributor

Pawka commented May 2, 2023

Is there anywhere I can see your build output to get a better idea of what sections are collapsed? Or could you describe it in more detail?

Answering comment from the previous discussion (since it make more sense to keep context here). I think following rules would work:

  1. Grouping should be made per root test. E.g. subtest should not be logged as separate groups.
  2. Succeeded test gropus are collapsed.
  3. Groups with failed tests are expanded.

However there are some edge cases which should be handled such as timeouts or panics which does not make test as "failed". In such cases code block where failure happened also should be expanded.

@vitaliyf
Copy link

TeamCity: https://www.jetbrains.com/help/teamcity/service-messages.html and for example: https://github.com/onsi/ginkgo/blob/master/reporters/teamcity_report.go

@phisco
Copy link

phisco commented May 14, 2024

  • Grouping should be made per root test. E.g. subtest should not be logged as separate groups.

I arrived here looking exactly for this, it wasn't implemented in the end, right? CC @vitaliyf @dnephin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants