From fbb0800b94ba4e88aea2c463ad59068e911ef49c Mon Sep 17 00:00:00 2001 From: Daniel Nephin Date: Tue, 2 Feb 2021 20:28:28 -0500 Subject: [PATCH] golden: only create dir if update flag is set --- golden/golden.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/golden/golden.go b/golden/golden.go index 54102dd2..6026b448 100644 --- a/golden/golden.go +++ b/golden/golden.go @@ -175,13 +175,13 @@ func compare(actual []byte, filename string) (cmp.Result, []byte) { } func update(filename string, actual []byte) error { + if !*flagUpdate { + return nil + } if dir := filepath.Dir(filename); dir != "." { if err := os.MkdirAll(dir, 0755); err != nil { return err } } - if *flagUpdate { - return ioutil.WriteFile(Path(filename), actual, 0644) - } - return nil + return ioutil.WriteFile(Path(filename), actual, 0644) }