Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poll: Result from cmp.Comparison #198

Merged
merged 2 commits into from Apr 18, 2020
Merged

poll: Result from cmp.Comparison #198

merged 2 commits into from Apr 18, 2020

Conversation

dnephin
Copy link
Member

@dnephin dnephin commented Apr 10, 2020

This change allows poll.Check functions to use cmp.Comparison to indicate Success or Continue.

@dnephin dnephin force-pushed the poll-result-from-cmp branch 4 times, most recently from 2b7a2c0 to 53b1708 Compare April 10, 2020 20:06
@dnephin
assert: move comparison evaluation to internal
51eb8c2 
Moving Eval to internal allows other packages, such as poll and a future
x/suite to perform assertions using comparisons.
@dnephin
poll: Add Compare for building Check using cmp.Comparison
5d6c285 
Also fix a bug in ArgsFromComparisonCall not properly bounds checking
vdemeester
vdemeester approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@dnephin dnephin merged commit 90977a4 into gotestyourself:master Apr 18, 2020
@dnephin dnephin deleted the poll-result-from-cmp branch April 18, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dnephin @vdemeester