Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Potential Handle Leak? #875

Open
1 task done
stasos24 opened this issue Nov 28, 2023 · 1 comment
Open
1 task done

[BUG] Potential Handle Leak? #875

stasos24 opened this issue Nov 28, 2023 · 1 comment
Labels
bug

Comments

@stasos24
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

websocket/proxy.go

Line 70 in 6f5d213

resp, err := http.ReadResponse(br, connectReq)

According to https://pkg.go.dev/net/http#ReadResponse
Clients must call resp.Body.Close when finished reading resp.Body

Expected Behavior

defer resp.Body.Close() at 77?

Steps To Reproduce

No response

Anything else?

No response
@stasos24 stasos24 added the bug label Nov 28, 2023
@ghost
Copy link

ghost commented Dec 11, 2023

The handle conn is returned to the caller a few lines after the code linked from the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
Gorilla Web Toolkit
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stasos24