- use golang context pkg instead of gorilla/context to fix memory leaks #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change won't work with golang versions below 1.7 as the context pkg did not exist for those versions |
elithrar
suggested changes
Dec 5, 2018
elithrar
suggested changes
Dec 7, 2018
There was a problem hiding this comment.
Couple of last requests, @secracon -
- Update
doc.goto remove reference to the memory leak from the old context implementation - https://github.com/gorilla/sessions/blob/master/doc.go#L62 - The same again in
README.mdhttps://github.com/gorilla/sessions/blob/master/README.md#L62 - Update
.travis.ymlto only build from Go 1.7.x onwards
Let me know if you need me to pick this up if you're unable to find time.
elithrar
approved these changes
Dec 8, 2018
|
Thanks @secracon! |
|
You're welcome! |
3 tasks
giganteous
reviewed
Apr 2, 2019
|
Hi @elithrar, will there be a tagged release with this change? The latest tag Reason being is that as a consumer I want to avoid locking down to a commit and rely on semver instead so my dep manager does the heavy lifting. |
|
I think @elithrar will release a minor version when he can find time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If gorilla/sessions is used together with other solutions including gorilla/mux, then there is a big chance of memory leaks, because the request may change during it's lifetime due to shallow copying of the request when the request context is changing. Once the request is copied, and that copy is used instead, then the request can no longer be found as key in the global context store managed by gorilla/context. This way the expired contexts are remaining in memory forever.