Fixes #141 #142
Merged
Fixes #141 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elithrar
approved these changes
Aug 19, 2020
elithrar
suggested changes
Aug 19, 2020
There was a problem hiding this comment.
The CI builds fail here:
=== RUN TestRegisterEncoderStructIsZero
--- FAIL: TestRegisterEncoderStructIsZero (0.00s)
panic: reflect.Value.Interface: cannot return value obtained from unexported field or method [recovered]
panic: reflect.Value.Interface: cannot return value obtained from unexported field or method
|
@rzajac Can you PTAL at the CI failure and resolve? This does seem to pass in Go 1.15 ( |
|
The problem was I was checking for IsZero interface implementation in a wrong way. |
elithrar
approved these changes
Aug 22, 2020
|
@rzajac - thanks for this! |
kirr
pushed a commit
to joomcode/schema
that referenced
this pull request
Jul 30, 2021
* Fixes gorilla#141 * Fixes gorilla#141 - additional fix for go 1.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141
Summary of Changes