Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve contents.type #581

Merged
merged 2 commits into from Nov 24, 2022
Merged

fix: improve contents.type #581

merged 2 commits into from Nov 24, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Nov 21, 2022

improved jsonschema and added validations

closes #580

improved jsonschema and added validations

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Nov 21, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 21, 2022
@vercel vercel bot temporarily deployed to Preview November 21, 2022 01:34 Inactive
@caarlos0 caarlos0 added the bug Something isn't working label Nov 21, 2022
@caarlos0 caarlos0 added this to the v2.23.0 milestone Nov 21, 2022
@caarlos0 caarlos0 marked this pull request as ready for review November 21, 2022 01:34
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #581 (87a619a) into main (280c04f) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
+ Coverage   70.30%   70.32%   +0.01%     
==========================================
  Files          21       21              
  Lines        3139     3141       +2     
==========================================
+ Hits         2207     2209       +2     
  Misses        715      715              
  Partials      217      217              
Impacted Files Coverage Δ
files/files.go 86.86% <100.00%> (+0.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

arch/arch.go Outdated Show resolved Hide resolved
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview November 21, 2022 23:38 Inactive
@caarlos0 caarlos0 merged commit 2918f99 into main Nov 24, 2022
@caarlos0 caarlos0 deleted the nfpm-files-type branch November 24, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No warning/error for invalid package types
2 participants