Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to go 1.19 #542

Merged
merged 2 commits into from Aug 22, 2022
Merged

feat: upgrade to go 1.19 #542

merged 2 commits into from Aug 22, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Aug 22, 2022 •
edited

  • upgrade go
  • removed usage of ioutil, which was deprecated in go 1.18, we're using go 1.19 already.

@caarlos0
refactor: remove usage of ioutil
f920ea1 
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Aug 22, 2022
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 22, 2022
@vercel vercel bot temporarily deployed to Preview August 22, 2022 00:56 Inactive
@caarlos0 caarlos0 marked this pull request as ready for review August 22, 2022 00:56
@caarlos0 caarlos0 added the enhancement New feature or request label Aug 22, 2022
djgilcrease
djgilcrease approved these changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@djgilcrease djgilcrease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caarlos0
fix(ci): actually use go 1.19
e88a2ab 
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview August 22, 2022 12:26 Inactive
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #542 (e88a2ab) into main (0815f5e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #542   +/-   ##
=======================================
  Coverage   65.88%   65.88%           
=======================================
  Files          16       16           
  Lines        1996     1996           
=======================================
  Hits         1315     1315           
  Misses        535      535           
  Partials      146      146
Impacted Files Coverage Δ
apk/apk.go 71.91% <100.00%> (ø)
deb/deb.go 71.42% <100.00%> (ø)
internal/sign/pgp.go 65.31% <100.00%> (ø)
internal/sign/rsa.go 62.50% <100.00%> (ø)
rpm/rpm.go 69.40% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit 437d9ef into main Aug 22, 2022
@caarlos0 caarlos0 deleted the iotil branch August 22, 2022 12:39
@caarlos0 caarlos0 changed the title refactor: remove usage of ioutil feat: upgrade to go 1.19 Aug 22, 2022
@caarlos0 caarlos0 added this to the v2.19.0 milestone Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djgilcrease djgilcrease djgilcrease approved these changes

Assignees

@caarlos0 caarlos0

Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v2.19.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@caarlos0 @djgilcrease