Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: json schema #533

Merged
merged 1 commit into from Jul 28, 2022
Merged

fix: json schema #533

merged 1 commit into from Jul 28, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jul 27, 2022

the jsonschema lib was updated, and now only supports json tags...

this duplicates the json and yaml tags, which is horrible and I'm happy to hear if there's a better way...

invopop/jsonschema#23

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Jul 27, 2022
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 27, 2022
@vercel vercel bot temporarily deployed to Preview July 27, 2022 17:51 Inactive
@caarlos0 caarlos0 marked this pull request as ready for review July 27, 2022 17:52
@caarlos0 caarlos0 added the bug Something isn't working label Jul 27, 2022
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #533 (dad501f) into main (d815894) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #533   +/-   ##
=======================================
  Coverage   65.88%   65.88%           
=======================================
  Files          16       16           
  Lines        1996     1996           
=======================================
  Hits         1315     1315           
  Misses        535      535           
  Partials      146      146           
Impacted Files Coverage Δ
files/files.go 86.66% <ø> (ø)
nfpm.go 86.88% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d815894...dad501f. Read the comment docs.

Copy link
Member

@erikgeiser erikgeiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is a better way. I'd do it the same way.

Copy link
Contributor

@djgilcrease djgilcrease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caarlos0 caarlos0 merged commit 51b893d into main Jul 28, 2022
@caarlos0 caarlos0 deleted the schema branch July 28, 2022 12:53
@github-actions github-actions bot added this to the v2.17.0 milestone Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants