Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove empty_folders for good #522

Merged
merged 2 commits into from Jun 14, 2022
Merged

feat: remove empty_folders for good #522

merged 2 commits into from Jun 14, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Jun 14, 2022

deprecated for a long time now, let's remove it!

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 added the enhancement New feature or request label Jun 14, 2022
@caarlos0 caarlos0 added this to the v2.17.0 milestone Jun 14, 2022
@caarlos0 caarlos0 requested a review from erikgeiser June 14, 2022 12:42
@caarlos0 caarlos0 self-assigned this Jun 14, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 14, 2022
@caarlos0 caarlos0 marked this pull request as ready for review June 14, 2022 12:42
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #522 (e2540d5) into main (8e17486) will decrease coverage by 0.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #522      +/-   ##
==========================================
- Coverage   66.16%   65.88%   -0.29%     
==========================================
  Files          16       16              
  Lines        2013     1996      -17     
==========================================
- Hits         1332     1315      -17     
- Misses        533      535       +2     
+ Partials      148      146       -2     
Impacted Files Coverage Δ
nfpm.go 86.88% <ø> (+0.38%) ⬆️
files/files.go 86.66% <0.00%> (-2.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e17486...e2540d5. Read the comment docs.

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview June 14, 2022 12:51 Inactive
Copy link
Contributor

@djgilcrease djgilcrease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caarlos0 caarlos0 merged commit 1e0d944 into main Jun 14, 2022
@caarlos0 caarlos0 deleted the empty branch June 14, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants