fix: switch to use gopenpgp #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/goreleaser/nfpm/53masRUjEYWDV8f8KmPrGeBRSosC |
pull-request-size
bot
added
the
size/L
djgilcrease
force-pushed
the
drop-crypto-openpgp
branch
from
0a50803
to
d5c4e11
Compare
djgilcrease
force-pushed
the
drop-crypto-openpgp
branch
from
d5c4e11
to
62d9c26
Compare
djgilcrease
force-pushed
the
drop-crypto-openpgp
branch
from
62d9c26
to
1fddf04
Compare
djgilcrease
force-pushed
the
drop-crypto-openpgp
branch
from
1fddf04
to
e4e86e1
Compare
djgilcrease
pushed a commit
to digitalxero/go-crypto
that referenced
this pull request
Apr 5, 2021
…ature.IssuerKeyId` == `signer.PrivateKey.KeyId` This fixes a bug in rpm < v4.13.0 that prevents it from using subkey.KeyID to verify a signed package https://bugzilla.redhat.com/show_bug.cgi?id=1225133 https://bugzilla.redhat.com/show_bug.cgi?id=227632 This change is also required for goreleaser/nfpm#315
djgilcrease
force-pushed
the
drop-crypto-openpgp
branch
from
e4e86e1
to
c4acb0b
Compare
djgilcrease
changed the title
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
==========================================
- Coverage 70.24% 70.13% -0.12%
==========================================
Files 9 9
Lines 1109 1135 +26
==========================================
+ Hits 779 796 +17
- Misses 204 209 +5
- Partials 126 130 +4
Continue to review full report at Codecov.
|
djgilcrease
force-pushed
the
drop-crypto-openpgp
branch
from
c4acb0b
to
1fbacc7
Compare
djgilcrease
force-pushed
the
drop-crypto-openpgp
branch
from
1fbacc7
to
7b3bbe3
Compare
djgilcrease
force-pushed
the
drop-crypto-openpgp
branch
from
7b3bbe3
to
7524282
Compare
caarlos0
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
I don't know a lot of openpgp, but this looks good to me 🤘
(assuming we remove the replaces on go.mod once the prs are merged)
Thanks for the hard work on this @djgilcrease 🤘
djgilcrease
force-pushed
the
drop-crypto-openpgp
branch
from
7524282
to
1a91f10
Compare
djgilcrease
changed the title
djgilcrease
force-pushed
the
drop-crypto-openpgp
branch
from
1a91f10
to
e339dec
Compare
djgilcrease
force-pushed
the
drop-crypto-openpgp
branch
from
e339dec
to
d63a5ff
Compare
With Googles anouncement that x/crypto/openpgp is depreciated golang/go#44226 we have decided to switch to github.com/ProtonMail/gopenpgp & github.com/ProtonMail/go-crypto/openpgp
djgilcrease
force-pushed
the
drop-crypto-openpgp
branch
from
d63a5ff
to
c093462
Compare
caarlos0
approved these changes
Apr 8, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Googles anouncement that x/crypto/openpgp is depreciated golang/go#44226 we have decided to switch to github.com/ProtonMail/gopenpgp & github.com/ProtonMail/go-crypto/openpgp
waiting-on: ProtonMail/go-crypto#79
waiting-on: ProtonMail/gopenpgp#126
closes #276
closes #280