Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: clean up the acceptance tests #292

Merged
merged 1 commit into from
Apr 15, 2021
Merged

test: clean up the acceptance tests #292

merged 1 commit into from
Apr 15, 2021

Conversation

djgilcrease
Copy link
Contributor

@djgilcrease djgilcrease commented Feb 3, 2021

  • Reduce the number of docker files
  • Add additional arch testing
  • Clean up the test code to reduce the duplication
  • Add a test that covers the example in Deep copy for directories #285
  • Make the acceptance tests run in parallel for each type [deb, apk, rpm]
  • Finish refactoring rpm specific tests
  • Finish refactoring deb specific tests

closes #285

@vercel
Copy link

vercel bot commented Feb 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/goreleaser/nfpm/5sbm64dBCF6XKyTJTMaTFyT7bnNY
✅ Preview: https://nfpm-git-issue-285-goreleaser.vercel.app

@vercel vercel bot temporarily deployed to Preview February 3, 2021 22:48 Inactive
@vercel vercel bot temporarily deployed to Preview February 3, 2021 23:01 Inactive
@vercel vercel bot temporarily deployed to Preview February 3, 2021 23:20 Inactive
@vercel vercel bot temporarily deployed to Preview February 3, 2021 23:24 Inactive
@vercel vercel bot temporarily deployed to Preview February 3, 2021 23:41 Inactive
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #292 (6f26b08) into master (7701bb9) will decrease coverage by 0.23%.
The diff coverage is 89.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #292      +/-   ##
==========================================
- Coverage   70.21%   69.97%   -0.24%     
==========================================
  Files           9        9              
  Lines        1138     1149      +11     
==========================================
+ Hits          799      804       +5     
- Misses        209      213       +4     
- Partials      130      132       +2     
Impacted Files Coverage Δ
internal/glob/glob.go 78.94% <71.42%> (-2.88%) ⬇️
nfpm.go 85.32% <93.10%> (-1.09%) ⬇️
files/files.go 95.89% <100.00%> (ø)
apk/apk.go 70.04% <0.00%> (-0.43%) ⬇️
deb/deb.go 66.11% <0.00%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7701bb9...6f26b08. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview February 3, 2021 23:44 Inactive
@vercel vercel bot temporarily deployed to Preview February 3, 2021 23:50 Inactive
@vercel vercel bot temporarily deployed to Preview April 15, 2021 19:13 Inactive
@djgilcrease djgilcrease changed the title WIP: test: clean up the acceptance tests test: clean up the acceptance tests Apr 15, 2021
@vercel vercel bot temporarily deployed to Preview April 15, 2021 19:18 Inactive
@vercel vercel bot temporarily deployed to Preview April 15, 2021 19:20 Inactive
@vercel vercel bot temporarily deployed to Preview April 15, 2021 19:28 Inactive
@vercel vercel bot temporarily deployed to Preview April 15, 2021 19:40 Inactive
@vercel vercel bot temporarily deployed to Preview April 15, 2021 19:42 Inactive
@caarlos0 caarlos0 merged commit 4107794 into master Apr 15, 2021
@caarlos0 caarlos0 deleted the issue-285 branch April 15, 2021 20:25
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deep copy for directories
2 participants