Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle multiline input for the Debian description field #119

Merged
merged 1 commit into from Feb 18, 2020

Conversation

djboris9
Copy link
Contributor

Hi There

The description field in the DEB control file supports multiline/verbatim input. It is done by indenting the lines by two spaces. Before this patch, the control file was broken if a user wanted to supply a multiline description.

Blank lines by using a full-stop-character are not implemented as it requires to convert the whole block to a 1-level intended block instead of the verbatim 2-level intended block.

Ref: debian-policy

The description field in the DEB control file supports multiline/verbatim
input. It is done by indenting the lines by two spaces. Before this patch,
the control file was broken if a user wanted to supply a multiline description.
@codecov-io
Copy link

Codecov Report

Merging #119 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   71.34%   71.57%   +0.22%     
==========================================
  Files           5        5              
  Lines         499      503       +4     
==========================================
+ Hits          356      360       +4     
  Misses         90       90              
  Partials       53       53
Impacted Files Coverage Δ
deb/deb.go 72.33% <100%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 690f627...5c4451c. Read the comment docs.

@caarlos0 caarlos0 merged commit 4daa0df into goreleaser:master Feb 18, 2020
@caarlos0
Copy link
Member

thanks for the PR :)

@caarlos0
Copy link
Member

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@goreleaser goreleaser locked as resolved and limited conversation to collaborators Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants