Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoReleaser Pro for Air Gapped Environments License Key Verification #4371

Open
3 tasks done
ryancurrah opened this issue Oct 15, 2023 · 3 comments
Open
3 tasks done
Assignees
Labels
enhancement New feature or request

Comments

@ryancurrah
Copy link
Contributor

ryancurrah commented Oct 15, 2023

Is your feature request related to a problem? Please describe.

Our company is restricting internet access for builds.

Describe the solution you'd like

Support for offline license key verification.

Describe alternatives you've considered

Nothing.

Search

  • I did search for other open and closed issues before opening this

Supporter

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

License key verification URL not working in an air gapped environment: https://api.gumroad.com/v2/licenses/verify

@ryancurrah ryancurrah added enhancement New feature or request triage Issue pending triage by one of the maintainers labels Oct 15, 2023
@ryancurrah ryancurrah changed the title GoReleaser Pro Air Gapped Environment GoReleaser Pro Air Gapped Environment - License Verification Oct 15, 2023
@ryancurrah ryancurrah changed the title GoReleaser Pro Air Gapped Environment - License Verification GoReleaser Pro for Air Gapped Environment License Key Verification Oct 15, 2023
@ryancurrah ryancurrah changed the title GoReleaser Pro for Air Gapped Environment License Key Verification GoReleaser Pro for Air Gapped Environments License Key Verification Oct 15, 2023
@caarlos0
Copy link
Member

Its a good idea, I don't have a solution for it though... open to suggestions though.

@caarlos0 caarlos0 removed the triage Issue pending triage by one of the maintainers label Oct 17, 2023
@ryancurrah
Copy link
Contributor Author

My only thought is a custom license check implementation or maybe gumroad has some guidance for offline key checks.

@caarlos0
Copy link
Member

caarlos0 commented Nov 1, 2023

My only thought is a custom license check implementation or maybe gumroad has some guidance for offline key checks.

unfortunately, it seems that only online validation...

One thing I could think off is something that makes an "air gapped key" from a valid key, in some format that contains an expiration date... then the air-gapped keys would be short-lived (1 day or something like that), and you wouldn't be able to gen one without a valid license.

That idea would be hell to maintain if the user (you) had to update it manually, unless we consider that the key generation could access the internet to gen the key, and pass it down to the rest of thing, which is air-gapped... but I never worked with air-gapped CI, so I don't know whats common or not...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants