different behavior for extra file trees included in archives and nfpms.
#3655
Assignees
Labels
bug
Something isn't working
Comments
ioga
added
bug
3 tasks
|
is #3656 what you are looking for? |
caarlos0
added a commit
that referenced
this issue
Dec 27, 2022
with this patch, a config like:
```yaml
archives:
- format: tar.gz
# this name template makes the OS and Arch compatible with the results of uname.
name_template: >-
{{ .ProjectName }}_
{{- title .Os }}_
{{- if eq .Arch "amd64" }}x86_64
{{- else if eq .Arch "386" }}i386
{{- else }}{{ .Arch }}{{ end }}
{{- if .Arm }}v{{ .Arm }}{{ end }}
rlcp: true
files:
- src: "build/**/*"
dst: .
nfpms:
- package_name: foo
contents:
- src: "build/**/*"
dst: usr/share/foo
formats:
- apk
```
will eval this:
<img width="1384" alt="CleanShot 2022-12-21 at 22 21 00@2x"
src="https://user-images.githubusercontent.com/245435/209034244-7c31b5f7-cfcd-4825-bb2f-7dd463c5286a.png">
as much as I would like to make this the default, it would be a breaking
change, so we really can't do it.
If `dst` is empty, it'll have the same behavior as before (no rlcp), and
if `strip_parent` is set, it will also still have the same behavior.
Finally, if the format is binary, `rlcp` is ignored too (as it doesn't
make sense).
So, this only changes if:
- your format is not binary; and
- you have files with `src` and `dst` set
Then, goreleaser will warn you to set `rlcp: true`.
## todo
- [x] docs
- [x] more tests probably
- [x] any ideas for a better name for the new config option?
fixes #3655
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
archivesconfig works differently fromnpmfswhen including subtrees.This was also discussed on discord: https://discord.com/channels/890434333251362866/1035159881210146916/threads/1054929081990381588
How can we reproduce this?
Let's say we have a file structure:
Case 1: I'd like to include it as is, stripping the
build/prefix, i.e. include:With npmfs I can do:
When I try the same with
archives:- "build/webui/**/*"will outputbuild/webui/react/robots.txt- dst: webuiwill outputwebui/build/webui/react/robots.txtstrip_parentoption with dst will output flattenedwebui/robots.txt,webui/index.html,webui/deploy.html(and incidentally cause a filename collision withindex.htmlin this example)i.e.
archivesbehaves differently, and there's no way to do what npmfs can do.Case 2: If I want to strip
build/prefix and include these files under a different path/usr/share/derp, e.g.with npmfs I can do:
Similarly to case 1, I could not find any way to do that.
goreleaser version
GoReleaser Check
Search
Code of Conduct
Additional context
No response
The text was updated successfully, but these errors were encountered: