Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to template archives.files.info #3630

Merged
merged 1 commit into from Dec 14, 2022
Merged

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Dec 11, 2022

this allows to template the owner, group and mtime in file infos inside archives.

should help towards reproducible builds!

goes well with #3618

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Dec 11, 2022
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 11, 2022
@vercel vercel bot temporarily deployed to Preview December 11, 2022 17:12 Inactive
@caarlos0 caarlos0 added the enhancement New feature or request label Dec 11, 2022
@caarlos0 caarlos0 marked this pull request as ready for review December 11, 2022 17:12
@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Merging #3630 (9b82464) into main (ddf7660) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3630      +/-   ##
==========================================
+ Coverage   83.63%   83.66%   +0.02%     
==========================================
  Files         117      117              
  Lines        9839     9856      +17     
==========================================
+ Hits         8229     8246      +17     
  Misses       1299     1299              
  Partials      311      311              
Impacted Files Coverage Δ
pkg/config/config.go 95.21% <ø> (ø)
internal/archivefiles/archivefiles.go 100.00% <100.00%> (ø)
pkg/archive/gzip/gzip.go 71.87% <100.00%> (ø)
pkg/archive/tar/tar.go 76.47% <100.00%> (ø)
pkg/archive/zip/zip.go 70.58% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit 2e5a8e5 into main Dec 14, 2022
@caarlos0 caarlos0 deleted the archive-info-tmpl branch December 14, 2022 15:16
@github-actions github-actions bot added this to the v1.14.0 milestone Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant