fix: warn if list has multiple files with same name #3607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
pull-request-size
bot
added
the
size/S
Codecov Report
@@ Coverage Diff @@
## main #3607 +/- ##
==========================================
+ Coverage 83.83% 83.84% +0.01%
==========================================
Files 117 117
Lines 9798 9807 +9
==========================================
+ Hits 8214 8223 +9
Misses 1275 1275
Partials 309 309
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List()"materializes" the filters, so its used everywhere... if we have multiple files with the same name there, its likely some filter wasn't enough, or that the user configuration is faulty. Either way, we should warn about it to help prevent release issues (like duplicated assets on github).