Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve schema for signs #3603

Merged
merged 1 commit into from Nov 30, 2022
Merged

fix: improve schema for signs #3603

merged 1 commit into from Nov 30, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Nov 29, 2022

adds all the options allowed in the artifacts field to the schema

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@caarlos0 caarlos0 self-assigned this Nov 29, 2022
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 29, 2022
@vercel vercel bot temporarily deployed to Preview November 29, 2022 01:42 Inactive
@caarlos0 caarlos0 added the enhancement New feature or request label Nov 29, 2022
@caarlos0 caarlos0 marked this pull request as ready for review November 29, 2022 01:43
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #3603 (26cd75f) into main (c2adc17) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3603   +/-   ##
=======================================
  Coverage   83.83%   83.83%           
=======================================
  Files         117      117           
  Lines        9798     9798           
=======================================
  Hits         8214     8214           
  Misses       1275     1275           
  Partials      309      309           
Impacted Files Coverage Δ
pkg/config/config.go 95.21% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit e72ab30 into main Nov 30, 2022
@caarlos0 caarlos0 deleted the schema branch November 30, 2022 00:38
@github-actions github-actions bot added this to the v1.14.0 milestone Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant