Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing digests on manifests #3602

Merged
merged 2 commits into from Nov 29, 2022
Merged

fix: missing digests on manifests #3602

merged 2 commits into from Nov 29, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Nov 28, 2022

it was missing the digest parsing for the manifest, and there were no tests covering it.

now the tests are there, and so is the fix.

refs #3599

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 28, 2022
@caarlos0 caarlos0 self-assigned this Nov 28, 2022
@caarlos0 caarlos0 added the bug Something isn't working label Nov 28, 2022
@vercel vercel bot temporarily deployed to Preview November 28, 2022 23:50 Inactive
@vercel vercel bot temporarily deployed to Preview November 28, 2022 23:52 Inactive
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #3602 (274b9b3) into main (f05f3b5) will decrease coverage by 0.04%.
The diff coverage is 55.00%.

@@            Coverage Diff             @@
##             main    #3602      +/-   ##
==========================================
- Coverage   83.88%   83.83%   -0.05%     
==========================================
  Files         117      117              
  Lines        9790     9798       +8     
==========================================
+ Hits         8212     8214       +2     
- Misses       1271     1275       +4     
- Partials      307      309       +2     
Impacted Files Coverage Δ
internal/pipe/docker/api.go 100.00% <ø> (ø)
internal/pipe/docker/api_docker.go 83.63% <53.84%> (-4.60%) ⬇️
internal/pipe/docker/manifest.go 94.11% <57.14%> (-2.83%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caarlos0 caarlos0 merged commit c2adc17 into main Nov 29, 2022
@caarlos0 caarlos0 deleted the digest-manifest branch November 29, 2022 00:30
@github-actions github-actions bot added this to the v1.14.0 milestone Nov 29, 2022
caarlos0 added a commit that referenced this pull request Nov 29, 2022
it was missing the digest parsing for the manifest, and there were no
tests covering it.

now the tests are there, and so is the fix.

refs #3599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant