Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): allow to template env #3592

Merged
merged 3 commits into from Nov 25, 2022
Merged

feat(build): allow to template env #3592

merged 3 commits into from Nov 25, 2022

Conversation

caarlos0
Copy link
Member

@caarlos0 caarlos0 commented Nov 24, 2022

GoReleaser evolved a lot since the last time I tried to implement this >1 year ago.
Now its 100% possible, and way simpler to do it!

closes #3580
refs #2583

@caarlos0 caarlos0 added the enhancement New feature or request label Nov 24, 2022
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 24, 2022
@caarlos0 caarlos0 changed the title feat(scope): allow to template env feat(build): allow to template env Nov 24, 2022
@vercel vercel bot temporarily deployed to Preview November 24, 2022 20:00 Inactive
closes #3580
refs #2583

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview November 24, 2022 20:01 Inactive
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #3592 (c9caff3) into main (a1305d3) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3592      +/-   ##
==========================================
+ Coverage   83.87%   83.93%   +0.05%     
==========================================
  Files         117      117              
  Lines        9751     9766      +15     
==========================================
+ Hits         8179     8197      +18     
+ Misses       1268     1265       -3     
  Partials      304      304              
Impacted Files Coverage Δ
internal/builders/golang/build.go 80.86% <100.00%> (+1.05%) ⬆️
internal/pipe/build/build.go 89.47% <100.00%> (+1.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview November 24, 2022 20:15 Inactive
@caarlos0 caarlos0 merged commit 1b8395d into main Nov 25, 2022
@caarlos0 caarlos0 deleted the build-env-tmpl branch November 25, 2022 18:26
@github-actions github-actions bot added this to the v1.14.0 milestone Nov 25, 2022
@orirawlings orirawlings mentioned this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow templating for env vars within build, and build overrides
1 participant